-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade test dependencies & fix Falcon warning #588
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comments for reviewers
setup.py
Outdated
], | ||
# pip install -e ".[testing_without_asyncio]" | ||
"testing_without_asyncio": test_dependencies, | ||
# pip install -e ".[testing]" | ||
"testing": async_test_dependencies, | ||
# pip install -e ".[adapter_testing]" | ||
"adapter_testing": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Organized the optional dependencies by moving test-related ones to this group
@@ -50,7 +50,11 @@ def _to_bolt_request(self, req: Request) -> BoltRequest: | |||
) | |||
|
|||
def _write_response(self, bolt_resp: BoltResponse, resp: Response): | |||
resp.body = bolt_resp.body | |||
if falcon_version.__version__.startswith("2."): | |||
resp.body = bolt_resp.body |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
response.text
does not exist in 2.x
if falcon_version.__version__.startswith("2."): | ||
resp.body = bolt_resp.body | ||
else: | ||
resp.text = bolt_resp.body |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
response.body
is deprecated in 3.x
@@ -18,6 +20,13 @@ | |||
from tests.utils import remove_os_env_temporarily, restore_os_env | |||
|
|||
|
|||
def new_falcon_app(): | |||
if falcon.version.__version__.startswith("2."): | |||
return falcon.API() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
falcon.API
is deprecated in 3.x. However, the new recommended way falcon.App
does not exist in 2.x
Codecov Report
@@ Coverage Diff @@
## main #588 +/- ##
==========================================
- Coverage 91.53% 91.52% -0.02%
==========================================
Files 169 169
Lines 5707 5709 +2
==========================================
+ Hits 5224 5225 +1
- Misses 483 484 +1
Continue to review full report at Codecov.
|
👋 Let me know if you have any comments on this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Thanks for the review! |
This pull request upgrades the dependencies in testing. Also, it resolves a deprecation warning in Falcon 3.x.
Category (place an
x
in each of the[ ]
)slack_bolt.App
and/or its core componentsslack_bolt.async_app.AsyncApp
and/or its core componentsslack_bolt.adapter
/docs
Requirements (place an
x
in each[ ]
)Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.sh
after making the changes.